fix(test): set --max-old-space-size=6144 on test:coverage to prevent OOM under --runInBand by PierreBrisorgueil · Pull Request #3554 · pierreb-devkit/Node

PierreBrisorgueil · 2026-05-01T06:59:50Z

Summary

Adds --max-old-space-size=6144 to test:coverage NODE_OPTIONS
Prevents OOM when downstream projects (trawl_node, etc.) run coverage on larger suites
Eliminates the need for downstream patches that get silently stripped by /update-stack --theirs

Why

test:coverage runs jest --runInBand — single Node process, no worker children. The workerIdleMemoryLimit: '512MB' added in #3550 only recycles worker processes, so it doesn't apply on coverage runs.

Without an explicit cap, Node defaults to ~2 GB old-space. Devkit's own ~18 suites fit, but trawl_node (214 suites) immediately OOMs at 1.9 GB on the chore/update-stack-2026-05-01 propagation run today.

Trawl had a downstream patch setting 6144 — the recent /update-stack propagation wiped it via --theirs (cf. feedback_update_stack_theirs_wipes_patches), causing the OOM. Restoring it locally would just recreate the same drift. Fix it upstream.

Test plan

CI green (devkit's own coverage continues to pass — change is additive, only raises the cap)
After merge + propagation: trawl_node build(deps-dev): bump eslint from 7.11.0 to 7.12.0 #1073 update branch passes coverage with the upstream value, downstream package.json patch from commit 042fdc9e becomes redundant and can be dropped on the next /update-stack

Summary by CodeRabbit

Chores
- Improved memory allocation for test coverage execution.

…OOM under --runInBand `test:coverage` runs `jest --runInBand` (single Node process) so `workerIdleMemoryLimit` from #3550 does not apply — there are no worker children to recycle. Without an explicit heap cap, Node defaults to ~2 GB old-space which is enough for devkit (~18 suites) but immediately OOMs on larger downstream test suites (trawl_node hit OOM at 1.9 GB on 214 suites). Setting `--max-old-space-size=6144` matches the existing per-project override that downstream projects had to maintain locally as patches. Bumping it upstream eliminates the divergence and prevents the `feedback_update_stack_theirs_wipes_patches` failure mode where `/update-stack --theirs` silently strips the override. Sized for the largest known downstream (trawl_node ~214 suites peaks ~4.3 GB pre-fixes / ~2 GB post). Headroom keeps room for further growth without re-tuning. CI runners on lily ARC have ≥6 GiB, GitHub-hosted runners have 7 GiB — both fit. Note: `workerIdleMemoryLimit: '512MB'` from #3550 still applies for non- coverage parallel runs (`test:parallel-smoke`, etc.) where worker children exist.

coderabbitai · 2026-05-01T07:00:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fcec8b3a-ef9d-41be-9ca4-50d976da5327

📥 Commits

Reviewing files that changed from the base of the PR and between 3afaf3c and d06a830.

📒 Files selected for processing (1)

package.json

Walkthrough

The test:coverage npm script's NODE_OPTIONS was updated to include --max-old-space-size=6144 alongside existing flags --experimental-vm-modules and --expose-gc for improved memory allocation during test coverage execution.

Changes

Cohort / File(s)	Summary
Package Configuration `package.json`	Added `--max-old-space-size=6144` Node.js flag to the `test:coverage` script's `NODE_OPTIONS` for increased heap memory allocation during coverage tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

perf(test): explicit GC between suites — peak heap 1.87→1.64 GB (−12%) #3545: Also modifies the scripts.test:coverage NODE_OPTIONS in package.json with different Node.js flags (--expose-gc / GC reporter).

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change—adding --max-old-space-size=6144 to prevent OOM during test coverage runs.
Description check	✅ Passed	The description provides comprehensive context covering what changed, why it's needed, and includes a detailed test plan and related issue references, meeting the template requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/test-coverage-heap-cap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codacy-production · 2026-05-01T07:00:53Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

Copilot

Pull request overview

Updates the repository’s coverage test script to raise Node’s V8 old-space heap limit, preventing out-of-memory crashes when running large Jest suites under --runInBand in downstream projects.

Changes:

Add --max-old-space-size=6144 to NODE_OPTIONS for test:coverage.

codacy-production

Pull Request Overview

The pull request successfully increases the Node.js heap memory limit to 6GB for the test:coverage script to prevent Out-Of-Memory errors in large test suites. Codacy analysis indicates the changes are up to standards with no new issues. However, there is a concern regarding the choice of 6GB on environments with 7GB total RAM (like GitHub Actions), as this leaves very little overhead for the OS and non-heap memory, potentially leading to non-deterministic SIGKILL failures. Additionally, several other scripts using --runInBand remain at default limits, which may lead to similar OOM issues in those contexts.

About this PR

The memory limit increase is currently only applied to test:coverage. Other scripts that utilize --runInBand (e.g., test:all, test:unit, test:integration) are still subject to default Node.js memory limits. Consider evaluating if these should also be updated to ensure consistency and prevent OOM errors across the entire test suite.

Test suggestions

Verify that 'test:coverage' command executes with the 6GB memory limit applied.
Verify that other in-band scripts (test:all, test:integration) are not causing OOM in downstream projects or evaluate if they also need the memory increase.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify that other in-band scripts (test:all, test:integration) are not causing OOM in downstream projects or evaluate if they also need the memory increase.

_{TIP Improve review quality by adding custom instructions}
_{TIP How was this review? Give us feedback}

codecov · 2026-05-01T07:03:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (3afaf3c) to head (d06a830).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3554   +/-   ##
=======================================
  Coverage   87.87%   87.87%           
=======================================
  Files         128      128           
  Lines        3589     3589           
  Branches     1054     1054           
=======================================
  Hits         3154     3154           
  Misses        345      345           
  Partials       90       90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings May 1, 2026 06:59

Copilot started reviewing on behalf of PierreBrisorgueil May 1, 2026 07:00 View session

coderabbitai Bot approved these changes May 1, 2026

View reviewed changes

Copilot AI reviewed May 1, 2026

View reviewed changes

codacy-production Bot reviewed May 1, 2026

View reviewed changes

Comment thread package.json

PierreBrisorgueil merged commit a40e4c5 into master May 1, 2026
11 checks passed

PierreBrisorgueil deleted the fix/test-coverage-heap-cap branch May 1, 2026 07:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(test): set --max-old-space-size=6144 on test:coverage to prevent OOM under --runInBand#3554

fix(test): set --max-old-space-size=6144 on test:coverage to prevent OOM under --runInBand#3554
PierreBrisorgueil merged 1 commit intomasterfrom
fix/test-coverage-heap-cap

PierreBrisorgueil commented May 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 1, 2026 •

edited

Loading

Uh oh!

codacy-production Bot commented May 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codacy-production Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented May 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

PierreBrisorgueil commented May 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Related

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

codacy-production Bot commented May 1, 2026

Up to standards ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codacy-production Bot left a comment

Choose a reason for hiding this comment

Pull Request Overview

About this PR

Test suggestions

Uh oh!

Uh oh!

codecov Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PierreBrisorgueil commented May 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 1, 2026 •

edited

Loading

codecov Bot commented May 1, 2026 •

edited

Loading